Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Improves Giftwrapping #1126

Merged
merged 3 commits into from
Oct 14, 2023
Merged

[MIRROR] Improves Giftwrapping #1126

merged 3 commits into from
Oct 14, 2023

Conversation

SierraHelper
Copy link
Collaborator

Оригинальный PR: Baystation12#34157

🆑 emmanuelbassil
tweak: Now able to wrap crates/closets with gift wrapping paper; and to wrap humans with regular parcel wrapping paper. Both have the same behavior.
tweak: Can now destination tag and label gifts.
tweak: You now require a sharp item to open any wrapped parcel
tweak: No more instant wrapping. Time delay scales up the bigger the item you're wrapping is. Also uses more wrap depending on item size.
tweak: Can now clip foamclogs with any sharp item, not only wirecutters or the scalpel.
bugfix: Instant Tactical combat gift-wrapping is no longer possible. You need a strong grab and a delay to gift-wrap someone else, like handcuffs.
/🆑

Rewrote all of gift and giftwrap and made them work exactly like parcel wrap.
Gifts are now a resprited/renamed version of the smalldelivery item; with the renaming/respriting handled in Initialize(). As a result, destroyed obj/item/gift completely.
Likewise, gift_wrap is now a child of item/stack/package_wrap having the same functionality as cargo's wrapper. Now that their behavior is unified, each of these two items can do more than they did before.

Also made it that you require a sharp item to unwrap those items.

@SierraHelper SierraHelper requested a review from a team as a code owner October 11, 2023 15:22
@github-actions github-actions bot added 🗺️ Карты Issue или PR затрагивает карты ⛰️ Спрайты PR затрагивает спрайты 📂 Репозиторий PR затрагивает код репозитория labels Oct 11, 2023
@SierraHelper SierraHelper added the 📜 CL валиден Ченджлог не содержит ошибок label Oct 11, 2023
@SuhEugene SuhEugene merged commit 2a6912f into dev-sierra Oct 14, 2023
@SuhEugene SuhEugene deleted the upstream-pr-34157 branch October 14, 2023 18:21
SierraHelper added a commit that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪞 MIR ЯОЯ ⛰️ Спрайты PR затрагивает спрайты 📂 Репозиторий PR затрагивает код репозитория 📜 CL валиден Ченджлог не содержит ошибок 🗺️ Карты Issue или PR затрагивает карты
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants