Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix decals on open closets #1153

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[MIRROR] Fix decals on open closets #1153

merged 2 commits into from
Oct 18, 2023

Conversation

SierraHelper
Copy link
Collaborator

Оригинальный PR: Baystation12#34237

Hopefully fixes Baystation12#34200 for real this time.
I modified the icon generation for open and closed closets; Decal icon states used only for open/closed closets are suffixed with "_open" or "_closed", and icon states with neither suffix are used by open and closed closets. I renamed existing icon states to match this scheme, and I also created some open variations for decals that could use them. Given that different types of openables arrange their sprites differently, I figured this was a good way to fix all of them while avoiding duplicate/empty icon states.

closets
Seen here: Open closets using new sprites for vent and hole decals, stripe decals no longer disappearing on open closets, open medical crates no longer having broken decals, open wall closets having glass panel decals, and large crates no longer losing their decals when open.

🆑Qlonever
bugfix: Open crates, large crates, closets, and wall closets now use correct decal icons.
/:cl:

@SierraHelper SierraHelper requested a review from a team as a code owner October 18, 2023 05:50
@github-actions github-actions bot added the ⛰️ Спрайты PR затрагивает спрайты label Oct 18, 2023
@SierraHelper SierraHelper added the 📜 CL валиден Ченджлог не содержит ошибок label Oct 18, 2023
@SuhEugene SuhEugene merged commit d661faf into dev-sierra Oct 18, 2023
5 checks passed
@SuhEugene SuhEugene deleted the upstream-pr-34237 branch October 18, 2023 15:53
SierraHelper added a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪞 MIR ЯОЯ ⛰️ Спрайты PR затрагивает спрайты 📜 CL валиден Ченджлог не содержит ошибок
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some lockers have strange overlay inside when they open
3 participants