[MIRROR] Changes afterattacks to use_after #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuhEugene
force-pushed
the
upstream-pr-34332
branch
from
cc2c88d to
0c6c4d0
Compare
SuhEugene
approved these changes
Nov 23, 2023
auto-merge was automatically disabled
November 23, 2023 09:34
Rebase failed
SierraHelper
added a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Оригинальный PR: Baystation12#34332
🆑 emmanuelbassil
bugfix: Fixes being unable to place pills into beakers placed on a table/turf
bugfix: Fixes duct-taped and sticky papers not properly offsetting
/🆑
The only afterattacks that will remain are the rare ones that actually handle ranged behavior. No changes in this PR other than changing afterattack to use_after; dropping the proximity flag check, and returning TRUE where needed.
Beyond that, at most there are styling changes. Any bugs I fix on the way are listed on the changelog.
Kept afterattacks for guns, sprays, and magic spells as these have a ranged use.
Also kept them for mech_equipment, as the after_attacks there do not EXPLICITLY check for proximity so I'm not touching it just in case.
Updated documentation as needed.