[MIRROR] Fixes setOxyLoss() for humanoids #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuhEugene
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Оригинальный PR: Baystation12#34339
For humanoids, getOxyLoss() returns a percentage of oxygen_deprivation, and adjustOxyLoss() adjusts the raw value. In every place it's called, setOxyLoss() is given a percentage value even though it just calls adjustOxyLoss(). It also increases oxygen_deprivation when it should decrease it because of a misordered subtraction. Neither of these problems are relevant when setting oxygen_deprivation from 0 to 0, which is probably why they've gone unnoticed for so long.
To avoid sweeping changes, this PR just makes humans' setOxyLoss() convert percentage oxyLoss to raw oxygen_deprivation when calling adjustOxyLoss().
🆑Qlonever
bugfix: Rescuscitating an asystolic suffocation victim won't cause their oxygenation to plummet.
/:cl: