Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adherent Discharge #1653

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Adherent Discharge #1653

merged 9 commits into from
Feb 27, 2024

Conversation

Lexanx
Copy link

@Lexanx Lexanx commented Dec 21, 2023

Возвращает абилку Адхерентов бить электричеством

close #1424

Чейнджлог

🆑Lexanx
rscadd: Возвращена способность Адхерентов бить электричеством
  • Pull Request полностью завершен, мне не нужна помощь чтобы его закончить.
  • Я внимательно прочитал все свои изменения и багов в них не нашел.
  • Я запускал сервер со своими изменениями локально и все протестировал.

@Lexanx Lexanx requested a review from a team as a code owner December 21, 2023 15:51
@github-actions github-actions bot added the 🔉 Звуки PR затрагивает звуки label Dec 21, 2023
SuhEugene
SuhEugene requested changes Dec 21, 2023
View reviewed changes
Copy link

@SuhEugene SuhEugene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нельзя просто взять, обернуть код в // [SIERRA-ADD] и сказать что он теперь модульный... Увы.

Подказки как это делать:

code/_onclick/click.dm Outdated Show resolved Hide resolved
code/modules/organs/internal/species/adherent.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/human_powers.dm Outdated Show resolved Hide resolved
code/_onclick/click.dm Outdated Show resolved Hide resolved
code/modules/species/station/adherent.dm Outdated Show resolved Hide resolved
@Lexanx Lexanx requested a review from SuhEugene December 30, 2023 11:17
SuhEugene
SuhEugene previously requested changes Jan 2, 2024
View reviewed changes
Copy link

@SuhEugene SuhEugene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отлично. Почти идеально. Остались мелкие недочёты.

mods/adherent_discharge/README.md Outdated Show resolved Hide resolved
mods/_master_files/code/_onclick/click.dm Outdated Show resolved Hide resolved
mods/adherent_discharge/code/human_powers.dm Outdated Show resolved Hide resolved
mods/adherent_discharge/code/human_powers.dm Outdated Show resolved Hide resolved
sound/effects/discharge_on.ogg Outdated Show resolved Hide resolved
mods/_master_files/code/modules/species/station/adherent.dm Outdated Show resolved Hide resolved
mods/adherent_discharge/README.md Outdated Show resolved Hide resolved
mods/adherent_discharge/README.md Outdated Show resolved Hide resolved
mods/adherent_discharge/README.md Outdated Show resolved Hide resolved
mods/adherent_discharge/README.md Outdated Show resolved Hide resolved
@SuhEugene
Copy link

Ещё чуть-чуть... Почти всё идеально...

@Lexanx Lexanx marked this pull request as draft February 27, 2024 17:39
@Lexanx Lexanx marked this pull request as ready for review February 27, 2024 18:28
@LordNest LordNest dismissed SuhEugene’s stale review February 27, 2024 19:59

Изменения внесены

@LordNest LordNest merged commit 7e7659d into SierraBay:dev-sierra Feb 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordNest LordNest LordNest approved these changes

@SuhEugene SuhEugene SuhEugene left review comments

Assignees
No one assigned
Labels
🔉 Звуки PR затрагивает звуки
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Механ: Защитная система адхеранта
3 participants
@Lexanx @SuhEugene @LordNest