Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Change all machinery/attackby to use_tool #1696

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

SierraHelper
Copy link
Collaborator

Оригинальный PR: Baystation12#34305

🆑 emmanuelbassil
tweak: Microwaves no longer accept solutions that contain forbidden ingredients. Feedback now given on which ingredient is incompatible.
bugfix: Un/Re-Anchoring a machine now properly updates machine's power usage.
/🆑

So I know I said I'm going to try to avoid test merges but this is sadly an exception that will require one.

Some other things I did:

  • Removed a bunch of attackby code governing wrenching/unwrenching anchored objects that was exactly similar to obj/use_tool. Now that it's handled by obj/use_tool; all you need to do is set the OBJ_ANCHORABLE flag to get this behavior. Tested the instances I did this. Did NOT add new behavior to any items.
  • Small notice when examining an object that can be anchored/unanchored that it is possible to do so.
  • attackby for newcaster handled damaging it. Axed this completely and made it use existing standardized health; works like a charm.
  • Removed alot of 'add fingerprints' and 'add components'. These are handled by post_use_item and the parent obj/machinery/use_tool respectively; no need for repetition.
  • Fixed as much styling as I could; some of this code is really old.
  • Fixed an oversight on post_anchor_change where equipment power use did not change.
  • Effectively moved alot of wrenching code out to post_anchor_change(). Did this for items with existing wrench/unwrench behavior under attackby() and no construction steps otherwise. No new behavior, all backend.
  • Fixed oversight where pipe dispensers could work while unanchored and did not consume idle power.

@SierraHelper SierraHelper requested a review from a team as a code owner December 26, 2023 13:19
@github-actions github-actions bot added the 📂 Репозиторий PR затрагивает код репозитория label Dec 26, 2023
@SierraHelper SierraHelper added the 📜 CL валиден Ченджлог не содержит ошибок label Dec 26, 2023
@SuhEugene SuhEugene merged commit c55fd2b into dev-sierra Dec 26, 2023
14 checks passed
@SuhEugene SuhEugene deleted the upstream-pr-34305 branch December 26, 2023 16:35
SierraHelper added a commit that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪞 MIR ЯОЯ 📂 Репозиторий PR затрагивает код репозитория 📜 CL валиден Ченджлог не содержит ошибок
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants