Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPC Cooling organ #1782

Merged
merged 30 commits into from
Feb 27, 2024
Merged

IPC Cooling organ #1782

merged 30 commits into from
Feb 27, 2024

Conversation

Lexanx
Copy link

@Lexanx Lexanx commented Jan 7, 2024 •
edited
Loading

Орган охлаждения для ИПС и внешний охладитель в роботику для ИПС. Позже нужно будет его замапить где нибудь в робототехнике.

close #1493

Чейнджлог

🆑Lexanx
rscadd: Орган Охлаждения для ИПС
rscadd: Добавлен внешний охладитель для ИПС
/🆑
  • Pull Request полностью завершен, мне не нужна помощь чтобы его закончить.
  • Я внимательно прочитал все свои изменения и багов в них не нашел.
  • Я запускал сервер со своими изменениями локально и все протестировал.

@Lexanx Lexanx requested a review from a team as a code owner January 7, 2024 21:06
@github-actions github-actions bot added the ⛰️ Спрайты PR затрагивает спрайты label Jan 7, 2024
@SierraHelper SierraHelper added the 📜 CL валиден Ченджлог не содержит ошибок label Jan 7, 2024
@Lexanx Lexanx marked this pull request as draft January 7, 2024 21:08
@Lexanx Lexanx marked this pull request as ready for review January 7, 2024 23:28
SuhEugene
SuhEugene requested changes Jan 9, 2024
View reviewed changes
mods/ipc_cooling_unit/README.md Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/README.md Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/README.md Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/README.md Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/README.md Show resolved Hide resolved
mods/ipc_cooling_unit/code/external_cooling_device.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/external_cooling_device.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/machine.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/machine.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/machine.dm Outdated Show resolved Hide resolved
SuhEugene
SuhEugene reviewed Jan 23, 2024
View reviewed changes
code/__defines/mobs.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the 🗺️ Карты Issue или PR затрагивает карты label Jan 25, 2024
@Lexanx
Revert "update"
e6f97bd 
This reverts commit 7ef1d8c.
@github-actions github-actions bot removed the 🗺️ Карты Issue или PR затрагивает карты label Jan 25, 2024
SuhEugene
SuhEugene reviewed Jan 25, 2024
View reviewed changes
mods/ipc_cooling_unit/README.md Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/README.md Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/external_cooling_device.dm Outdated Show resolved Hide resolved
SuhEugene
SuhEugene previously requested changes Feb 10, 2024
View reviewed changes
Copy link

@SuhEugene SuhEugene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Избавляемся от неиспользуемой переменной interact
  2. Небольшой фикс имени переменной
  3. Мелкая красота в виде убирания лишнего энтера
  4. Фикс странного афтераттака
  5. Лишние ретёрны

Больше я ничего заметить не смог. Просто протыкай приняие предложений и всё должно быть замечательно

mods/ipc_cooling_unit/README.md Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/machine.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/machine.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/external_cooling_device.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/external_cooling_device.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/external_cooling_device.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/external_cooling_device.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/cooling_system.dm Outdated Show resolved Hide resolved
mods/ipc_cooling_unit/code/cooling_system.dm Outdated Show resolved Hide resolved
Lexanx and others added 11 commits February 14, 2024 00:49
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/README.md
33bc3a9 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/code/machine.dm
61a4ef3 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/code/machine.dm
f919117 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/code/cooling_system.dm
b2f271b 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/code/cooling_system.dm
223e1e8 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/code/external_cooling_device.dm
a5f16d0 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/code/external_cooling_device.dm
6794be7 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/code/external_cooling_device.dm
a453ea6 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx @SuhEugene
Update mods/ipc_cooling_unit/code/external_cooling_device.dm
01f2c97 
Co-authored-by: SuhEugene <[email protected]>
@Lexanx
Merge branch 'dev-sierra' into IPC-organ
86aeabf
@Lexanx
Update cooling_system.dm
d4c02ce
@LordNest LordNest requested a review from SuhEugene February 14, 2024 20:20
@LordNest LordNest dismissed SuhEugene’s stale review February 27, 2024 14:04

Всё пофиксили

@LordNest LordNest merged commit 409d619 into SierraBay:dev-sierra Feb 27, 2024
11 checks passed
SierraHelper added a commit that referenced this pull request Feb 27, 2024
@SierraHelper
Чейнджлог для PR #1782 [ci skip]
4c3d16d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordNest LordNest LordNest approved these changes

@SuhEugene SuhEugene Awaiting requested review from SuhEugene

Assignees
No one assigned
Labels
⛰️ Спрайты PR затрагивает спрайты 📜 CL валиден Ченджлог не содержит ошибок
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Запрос: Внутренний Орган ИПС
4 participants
@Lexanx @SuhEugene @LordNest @SierraHelper