[MIRROR] tweaked playsound, changes & fixes for storage items #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Оригинальный PR: Baystation12#34461
no changes people will notice, besides perhaps the quick gather corrections.
playsound and playsound_local return early on null sound sources
can_hold -> contents_allowed
cant_hold -> contents_banned
contents_allowed & contents_banned allow null instead of empty lists
collection_mode -> quick_gather_single
storage items correctly respect whether they can quick gather & which quick gather mode they are in
fixed quick gathering not working on turfs
toggle_gathering_mode verb respects distance
got rid of open_sound_played
corrected comments for /obj/item/storage member vars