-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automating the sift react native releases. #30
base: master
Are you sure you want to change the base?
Automating the sift react native releases. #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you haven't ran this workflow with the release step. If you don't want to publish an actual release, there are ways to use release-it
to run a pre-release, draft, etc.
https://github.com/release-it/release-it/blob/HEAD/docs/configuration.md#configuration
https://github.com/release-it/release-it/blob/HEAD/config/release-it.json#L39C11-L39C11
- name: Run tests | ||
run: npm test | ||
|
||
# Release arent available, uncomment below lines when release is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why the step to perform the release is commented out? Sounds like the release should actually run as part of this workflow?
# - name: Release the package | ||
# run: | | ||
# npm run release -- --yes | ||
# git push --follow-tags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we run git push
? I don't see that step in the release runbook
# Release arent available, uncomment below lines when release is available | ||
# - name: Release the package | ||
# run: | | ||
# npm run release -- --yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the runbook, it looks like the npm run release
command will ask for a TOTP to authenticate for NPM. Does this --yes
flag work around that?
Purpose:
Testing: