Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automating the sift react native releases. #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VinayakGadad
Copy link

Purpose:

Testing:

[Release/Perform the Release]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/2] user= workdir=
| npm WARN deprecated [email protected]: Use your platform's native performance.now() and performance.timeOrigin.
| npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
| npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated
| npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
| npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
| npm WARN deprecated [email protected]: some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
| npm WARN deprecated [email protected]: support for ECMAScript is superseded by `uglify-js` as of v3.13.0
| npm WARN deprecated [email protected]: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
| npm WARN deprecated @hapi/[email protected]: This version has been deprecated and is no longer supported or maintained
| npm WARN deprecated @hapi/[email protected]: This version has been deprecated and is no longer supported or maintained
| npm WARN deprecated @hapi/[email protected]: Moved to 'npm install @sideway/address'
| npm WARN deprecated @hapi/[email protected]: This version has been deprecated and is no longer supported or maintained
| npm WARN deprecated @hapi/[email protected]: Switch to 'npm install joi'
| npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
| npm WARN deprecated @react-native-community/[email protected]: This package has been renamed to 'react-native-builder-bob'. Please use it instead.
| npm WARN deprecated [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
| npm WARN deprecated [email protected]: Issues and pull requests filed against this version are not supported. See the React Native release support policy to learn more: https://github.com/reactwg/react-native-releases#releases-support-policy
| 
| > [email protected] prepare
| > bob build
| 
| ℹ Building target commonjs
| ℹ Cleaning up previous build at lib/commonjs
| ℹ Compiling 1 files in src with babel
| Browserslist: caniuse-lite is outdated. Please run:
|   npx update-browserslist-db@latest
|   Why you should do it regularly: https://github.com/browserslist/update-db#readme
| ✓ Wrote files to lib/commonjs
| ℹ Building target module
| ℹ Cleaning up previous build at lib/module
| ℹ Compiling 1 files in src with babel
| ✓ Wrote files to lib/module
| ℹ Building target typescript
| ℹ Cleaning up previous build at lib/typescript
| ℹ Generating type definitions with tsc
| ✓ Wrote definition files to lib/typescript
| 
| added 1751 packages, and audited 1752 packages in 17s
| 
| 141 packages are looking for funding
|   run `npm fund` for details
| 
| 48 vulnerabilities (16 moderate, 22 high, 10 critical)
| 
| To address issues that do not require attention, run:
|   npm audit fix
| 
| To address all issues (including breaking changes), run:
|   npm audit fix --force
| 
| Run `npm audit` for details.
[Release/Perform the Release]   ✅  Success - Main Install dependencies
[Release/Perform the Release] ⭐ Run Main Run tests
[Release/Perform the Release]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/3] user= workdir=
| 
| > [email protected] test
| > jest
| 
|  PASS  src/__tests__/index.test.tsx
|   ✎ todo write a test
| 
Test Suites: 1 passed, 1 total
| Tests:       1 todo, 1 total
| Snapshots:   0 total
| Time:        0.806 s
| Ran all test suites.
[Release/Perform the Release]   ✅  Success - Main Run tests
[Release/Perform the Release] ⭐ Run Main Check release on npm
[Release/Perform the Release]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/4] user= workdir=
| 0.1.9
[Release/Perform the Release]   ✅  Success - Main Check release on npm
[Release/Perform the Release] ⭐ Run Main Check release on GitHub
[Release/Perform the Release]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/5] user= workdir=
| v0.1.9
[Release/Perform the Release]   ✅  Success - Main Check release on GitHub
[Release/Perform the Release] ⭐ Run Post Set up Node.js
[Release/Perform the Release]   🐳  docker exec cmd=[node /var/run/act/actions/actions-setup-node@v2/dist/cache-save/index.js] user= workdir=
[Release/Perform the Release]   💬  ::debug::Caching for '' is not supported
[Release/Perform the Release]   ✅  Success - Post Set up Node.js
[Release/Perform the Release] 🏁  Job succeeded


@VinayakGadad VinayakGadad requested a review from a team August 1, 2023 22:31
Copy link

@btusakul-sift btusakul-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you haven't ran this workflow with the release step. If you don't want to publish an actual release, there are ways to use release-it to run a pre-release, draft, etc.

https://github.com/release-it/release-it/blob/HEAD/docs/configuration.md#configuration
https://github.com/release-it/release-it/blob/HEAD/config/release-it.json#L39C11-L39C11

- name: Run tests
run: npm test

# Release arent available, uncomment below lines when release is available

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the step to perform the release is commented out? Sounds like the release should actually run as part of this workflow?

# - name: Release the package
# run: |
# npm run release -- --yes
# git push --follow-tags

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we run git push? I don't see that step in the release runbook

# Release arent available, uncomment below lines when release is available
# - name: Release the package
# run: |
# npm run release -- --yes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the runbook, it looks like the npm run release command will ask for a TOTP to authenticate for NPM. Does this --yes flag work around that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants