Enable additional resource attributes for cluster metrics #547
Conversation
WalkthroughThe changes introduced in this pull request enhance the configuration templates for the OpenTelemetry Collector by adding new fields to support additional resource attributes and authentication methods for Kubernetes events. Specifically, the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
srikanthccv
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
charts/k8s-infra/templates/_config.tpl (1)
170-171: LGTM! The resource_attributes field enhances cluster metrics configuration.The addition of the
resource_attributesfield to theclusterMetricsConfigtemplate is well-integrated and follows Helm templating best practices:
- Uses proper YAML indentation (6 spaces) consistent with the rest of the file
- Correctly uses
toYamlfor converting the values to YAML format- Maintains the hierarchical structure of the configuration
Consider documenting the supported resource attributes in the chart's README.md or values.yaml to help users understand what attributes can be configured.
charts/k8s-infra/values.yaml (1)
261-271: Consider adding documentation for the new resource attributes.It would be helpful to add comments describing each resource attribute's purpose and the data it provides, similar to other configuration sections in this file.
Example:
resourceAttributes: + # -- Tracks the Quality of Service (QoS) class assigned to pods k8s.pod.qos_class: enabled: true + # -- Reports the version of kubelet running on nodes k8s.kubelet.version: enabled: true + # -- Identifies the container runtime in use (e.g., containerd, docker) container.runtime: enabled: true + # -- Reports the version of the container runtime container.runtime.version: enabled: true + # -- Captures the reason for the last container termination k8s.container.status.last_terminated_reason: enabled: true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
charts/k8s-infra/templates/_config.tpl(1 hunks)charts/k8s-infra/values.yaml(1 hunks)
🔇 Additional comments (1)
charts/k8s-infra/values.yaml (1)
261-271: LGTM! The new resource attributes enhance cluster monitoring capabilities.
The added resource attributes provide valuable telemetry data for:
- Pod QoS class monitoring for better scheduling insights
- Kubelet version tracking for compatibility management
- Container runtime monitoring for environment visibility
- Container termination reasons for improved debugging
Summary by CodeRabbit
resource_attributesfield for enhanced cluster metrics configuration.auth_typefield for specifying authentication methods for Kubernetes events.k8s.pod.qos_class,k8s.kubelet.version,container.runtime,container.runtime.version, andk8s.container.status.last_terminated_reason.These changes enhance monitoring capabilities and flexibility in configuration.