Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decrease the pad angle and remove the empty legend entries #6507

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Nov 22, 2024

Summary

  • the presence of padAngle adds a padding between adjacent values which appears as a chunk on pie chart.
  • since there were 0 entries also present they were consuming the padding still. removed the 0 entries.

Related Issues / PR's

Screenshots

image

image

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the bug Something isn't working label Nov 22, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 60c72e5 in 13 seconds

More details
  • Looked at 41 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/container/PanelWrapper/PiePanelWrapper.tsx:11
  • Draft comment:
    The import of isNaN from lodash-es is unnecessary. Consider using the built-in isNaN function instead to reduce bundle size.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import of isNaN from lodash-es is unnecessary since isNaN is a built-in JavaScript function. Using the built-in function can reduce bundle size and improve performance slightly.
2. frontend/src/container/PanelWrapper/PiePanelWrapper.tsx:113
  • Draft comment:
    Avoid using inline styles. Consider using CSS classes or styled components instead. This is applicable in multiple places, such as lines 182-186 and 190-192.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_HKMzZ3IzkpR2Nh18


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25
Copy link
Collaborator Author

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 enabled auto-merge (squash) November 22, 2024 10:59
@vikrantgupta25 vikrantgupta25 merged commit 96b5e09 into develop Nov 22, 2024
16 checks passed
@vikrantgupta25 vikrantgupta25 deleted the pie-chart-spacing branch November 22, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants