Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install-script): handle no sudo command scenerio #6924

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(install-script): handle no sudo command scenerio #6924

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
860fa4a
fix(install-script): handle no sudo command scenerio
prashant-shahi Jan 26, 2025
c0d8f8d
Merge branch 'main' into fix/install-no-sudo
prashant-shahi Jan 27, 2025
abea45f
Merge branch 'main' into fix/install-no-sudo
prashant-shahi Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions deploy/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,23 +301,29 @@ request_sudo() {
echo -e "Got it! Thanks!! 🙏\n"
echo -e "Okay! We will bring up the SigNoz cluster from here 🚀\n"
fi
fi
fi
}

echo ""
echo -e "👋 Thank you for trying out SigNoz! "
echo ""

sudo_cmd=""
docker_compose_cmd=""
docker_compose_cmd="docker compose"

# Check sudo permissions
if (( $EUID != 0 )); then
echo "🟡 Running installer with non-sudo permissions."
echo " In case of any failure or prompt, please consider running the script with sudo privileges."
echo ""
else
sudo_cmd="sudo"
if hash sudo 2>/dev/null; then
sudo_cmd="sudo"
else
echo "🟡 Running installer with root permissions but sudo command not found, running without sudo"
echo " In case of any failure or prompt, please consider installing sudo and running the script again."
echo ""
fi
fi

# Checking OS and assigning package manager
Expand Down Expand Up @@ -458,11 +464,10 @@ if ! is_command_present docker; then
fi

if has_docker_compose_plugin; then
echo "docker compose plugin is present, using it"
docker_compose_cmd="docker compose"
# Install docker-compose
echo "docker compose plugin found, using it"
else
docker_compose_cmd="docker-compose"
echo "docker compose plugin not found, using docker-compose instead"
if ! is_command_present docker-compose; then
request_sudo
install_docker_compose
Expand Down
Loading