Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearranged the order of attribute to align with documentation. #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

monikasoni
Copy link

The names assigned to product_id and product_type_id seem to be potentially swapped or incorrectly named based on their attribute names.

As result UIID does not match with documentation.

The UIID for the ZPC is a string that can be constructed using the following information:

The Manufacturer ID (Manufacturer Specific Command Class, 2 bytes)
The Product Type (Manufacturer Specific Command Class, 2 bytes)
The Product ID (Manufacturer Specific Command Class, 2 bytes)
The Firmware Target (Firmware Update Command Class, 1 byte)
The Hardware version (Version Command Class, 1 byte)

@rzr
Copy link
Collaborator

rzr commented Nov 22, 2023

Thanks, just curious what makes you think the mistake is in the code and not in the doc ?

@monikasoni
Copy link
Author

Shouldn't the retrieval of product_id be from ATTRIBUTE_MANUFACTURER_SPECIFIC_PRODUCT_ID instead of ATTRIBUTE_MANUFACTURER_SPECIFIC_PRODUCT_TYPE_ID?

And accordingly, shouldn't the retrieval of product_type_id be from ATTRIBUTE_MANUFACTURER_SPECIFIC_PRODUCT_TYPE_ID instead of ATTRIBUTE_MANUFACTURER_SPECIFIC_PRODUCT_ID?

@rzr
Copy link
Collaborator

rzr commented Jul 18, 2024

This change can not be merged yet, because to my knowledge it is pending on CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants