ci: Enable github CI for developers forks #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable to setup a reference system for building, it can be used for various automation (eg: github actions) Most of changes are isolated in this simple makefile that more or less script what has been described in readme file Signed-off-by: Philippe Coval <[email protected]>
Just run the native helper script in docker, it is not optimized for bandwidth but minimize duplication of changes. Signed-off-by: Philippe Coval <[email protected]>
Enable github actions that build any branches using docker along helper script. To reduces the dependency on github and avoid bringing more ambiguity or complexity most tasks are isolated at lowerlevel (in helper for cmake). More checks to come next, unit tests, lint etc. Relate-to: https://github.com/rzr/wisun-br-linux/actions/runs/11687474586/job/32545660605 Signed-off-by: Philippe Coval <[email protected]>
|
Very nice! However, I wonder if it make sense to involve docker and a makefile for a such simple CI. I assume we could do the same with only |
|
well it is developer preference,. IHMO Depending on docker is not ideal, but supporting it is nice (again it can be a reference that can help troubleshooting), I think there are benefits to have minimal (like this one) docker file in tree, something nice for DX one can build directly with a oneliner: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check status in source project:
https://github.com/rzr/wisun-br-linux/tree/phcoval/ci/review/main
https://github.com/rzr/wisun-br-linux/actions/runs/11687571871/job/32545978157