Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-TEMP] Updated endpoint for the Identify cluster from endpoint 0 to endpoint 1 #150

Conversation

shgutte
Copy link
Contributor

@shgutte shgutte commented Dec 2, 2024

Problem: Observing unsupported cluster for IDENTIFY cluster on endpoint 1
Solution: Updating the endpoint of the IDENTIFY cluster from 0 to 1
Testing Done: 917 SoC

@shgutte shgutte requested a review from a team as a code owner December 2, 2024 14:35
@shgutte shgutte changed the title [SL-UP] Adds changes for the Identify cluster endpoint 0 to endpoint 1 [SL-UP] Updated endpoint for the Identify cluster from endpoint 0 to endpoint 1 Dec 2, 2024
@shgutte shgutte changed the title [SL-UP] Updated endpoint for the Identify cluster from endpoint 0 to endpoint 1 [SL-Only] Updated endpoint for the Identify cluster from endpoint 0 to endpoint 1 Dec 2, 2024
@shgutte shgutte changed the title [SL-Only] Updated endpoint for the Identify cluster from endpoint 0 to endpoint 1 [SL-ONLY] Updated endpoint for the Identify cluster from endpoint 0 to endpoint 1 Dec 2, 2024
@mkardous-silabs
Copy link
Contributor

mkardous-silabs commented Dec 2, 2024

@shgutte Did you check if the other endpoints need to have the indentify cluster based on the specification requirements?
Also, why is this an sl-only PR? isn't the example on CSA?

@jmartinez-silabs
Copy link
Contributor

@mkardous-silabs see project-chip/connectedhomeip#36373 I fixed this on CSA.
It was originally a SL-UP on release 2.4-1.4. When doing the upstream, Andrei pointed out to that the Identify cluster can't be on endpoint 0. It must be on the device-type endpoint.

Actually, sorry @shgutte , this is a SL-TEMP. It won't be carried out anywhere else.

@jmartinez-silabs jmartinez-silabs added the sl-temp This TAG indicates that this commit is silabs-specific that will not be upstream or carried over. label Dec 2, 2024
@jmartinez-silabs jmartinez-silabs changed the title [SL-ONLY] Updated endpoint for the Identify cluster from endpoint 0 to endpoint 1 [SL-TEMP] Updated endpoint for the Identify cluster from endpoint 0 to endpoint 1 Dec 2, 2024
@mkardous-silabs mkardous-silabs merged commit 7d7c700 into SiliconLabsSoftware:release_2.5-1.4 Dec 2, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sl-temp This TAG indicates that this commit is silabs-specific that will not be upstream or carried over.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants