[CSA-CP]Bring matter_support changes to fix 917 NCP build fail in CI #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhmanda-silabs
changed the title
|
The testing section doesn't indicate that the binairies were tested. Can we validate that everything works as expected? The pr doesn't bring the gn changes to build with the lcd or external flash. is that expected? |
|
Bring the gn file changes too and testing also done on 917 NCP. Updated testing section. |
mkardous-silabs
approved these changes
Jan 28, 2025
jmartinez-silabs
approved these changes
Jan 28, 2025
mkardous-silabs
merged commit 2b1a12a
into
SiliconLabsSoftware:release_2.5-1.4
53 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI build is failing for 917 NCP boards as it has old matter_support pointer
Here, update matter_support changes to matter_sdk repo release branch
Testing
Verified build locally few apps and CI.
Verified commissioning and few commands on 917 NCP board.