Realtime API update #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 18, 2022 16:25
|
I used an older bait-and-switch technique to support the PCL (have the compiler link against a dummy assembly during builds, but load the correct assembly in the target project) - which might be why the build is currently failing. In theory, this technique wouldn't be needed in .NET Standard land. Perhaps moving everything to the new SDK might fix the build errors? |
|
Do you mean moving the CI pipeline to the new SDK too? |
antoniozh
force-pushed
the
dev-realtime-api
branch
from
3f85f48 to
bfee073
Compare
antoniozh
force-pushed
the
dev-realtime-api
branch
from
e3e2fae to
0a51e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the project to .NET Standard 2.0 and removed some wrappers. I also added NLog as a library and refactored the references to ILogger to NLog.ILogger.
With some tweaks and changes to the subscription code and room retrieval, subscribing to room message streams works now.