feat: ability to stop all extractors #119
Conversation
dprevost-LMI
changed the title
There was a problem hiding this comment.
@dprevost-LMI Can you add these new methods in readme docs as well?
dprevost-LMI
force-pushed
the
allow-to-stop-all-extractors
branch
3 times, most recently
from
1965941 to
891a7c5
Compare
dprevost-LMI
force-pushed
the
allow-to-stop-all-extractors
branch
from
97cf9f8 to
bb8f68b
Compare
example/src/assets/icons/play.png
Outdated
There was a problem hiding this comment.
The change cannot be seen since I used a tool to change the space colour from Gray to RBG, this. fixed the tintColor problem on iOS
|
Waiting on #123 merge to fix the player button s issue when clicking stop all |
dprevost-LMI
force-pushed
the
allow-to-stop-all-extractors
branch
from
708eeb3 to
1f3a0bf
Compare
|
Now waiting on #136 since some promise rejections are missing to thoroughly test the player after stopping everything! |
chore: wrong AudioWaveform import in App.tsx + delete recording button fix: wrong path chore: log error only when not stop by everything fix: missing promise.resolve chore: review `handleStopEverything` and `handleDeleteRecordings` fix: promises resolve too soon because of the stop everything changes fix: all error pass to onError should be an Error instance, not a string fix: move stopEverything in JS + clear all arrays for less leak chore: stop recorder also + remove logPromise chore: remove unneeded changes chore: expose `stopAllWaveFormExtractors` fix: better white delete icon chore: remove delete recodings fix: review array item handling since we clear the arrays chore: fix doc feat: make stopAllWaveFormExtractors work in iOS + remove stopRecording fix: remove everything from the player array to not increase forever chore: small renaming
dprevost-LMI
force-pushed
the
allow-to-stop-all-extractors
branch
from
1f3a0bf to
908217e
Compare
|
Rebased and retested on Android and iOS Screen.Recording.2024-11-19.at.6.50.32.AM.mov |
|
@kuldip-simform, when you have a minute, this PR is ready to be approved & merged! |
|
Hey, I'm just checking if there are still some chances to merge this one; otherwise, I will just close it! |
In a scenario where we want to use the audio player to load several audio messages for different conversations and where navigation between conversations is required only to show one conversation at a time, we need an efficient way to load the audio message but also to cancel nearly everything if we switch to another conversation.
In the above scenario, when navigating away from all those audio players being played or having their waveform extracted, we need to stop them. Otherwise, opening more and more conversations in a short period will bust resources (promises, players, extractors).
This PR provides a new
stopAllWaveFormExtractors, which, when called, stops all waveform extraction to free resources for the following conversation that will be loaded. Combined withstopAllPlayers, the newstopPlayersAndExtractorsin theuseAudioPlayerhook provides a way to stop everything around the audio players to ensure that no more resources are spent on the unmount screen.The new
Stop all players and extractosoption:Other:
CountDownLatchwas removed since it was not used anywhere.tintColorissue not to work