Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue on windows #357

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Conversation

fabinsch
Copy link
Collaborator

we encountered in the proxsuite-feedstock, here

D:\bld\proxsuite_1732720555127\work\include\proxsuite/linalg/veg/tuple.hpp(757,26): error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  757 |     return cat::template from_ref_to_result(
      |                          ^
1 warning and 1 error generated.
NMAKE : fatal error U1077: 'D:\bld\proxsuite_1732720555127\_build_env\Library\bin\cmake.exe' : return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
Traceback (most recent call last):
  File "C:\Miniforge\lib\site-packages\conda_build\build.py", line 2510, in build
    windows.build(
  File "C:\Miniforge\lib\site-packages\conda_build\windows.py", line 339, in build
    check_call_env(
  File "C:\Miniforge\lib\site-packages\conda_build\utils.py", line 406, in check_call_env
    return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
  File "C:\Miniforge\lib\site-packages\conda_build\utils.py", line 382, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['cmd.exe', '/d', '/c', 'conda_build.bat']' returned non-zero exit status 1

The patch recipe/fix-windows.patch is related to content in this PR.

jorisv
jorisv previously approved these changes Nov 28, 2024
@jorisv
Copy link
Contributor

jorisv commented Dec 4, 2024

@jorisv
Copy link
Contributor

jorisv commented Dec 4, 2024

The bug is fixed in clang 19. So I installed clang from conda-forge and I changed the workflow to use this version.

@jorisv jorisv merged commit 11497f7 into Simple-Robotics:devel Dec 4, 2024
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants