Skip to content

Commit

Permalink
Adjusts Cargo Market (#1377)
Browse files Browse the repository at this point in the history
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Long story short, cargo and command abuses the new reverse-engineered
suits and warning them as admins about it is getting quite tiring. So I
decided to put my hand to the craft and comment them out for now, until
a better way for them to be gotten is made.

I have also taken this opportunity to fix some of the longstanding
issues with cargo I have had, such as there missing sec masks in the
riot crate or there not being a way to get the swat items.

While I am still missing the properly developed versions with space
proofing and minor cold/head protection, the old non ARCS riot suit will
do for now.

This PR fixes
#1376

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Remove problematic items from cargo
- [x] Add proper swat crate

Opt:
- [x] Make proper swat set (soon:tm:)
- [x] Adjust the armor values to fit better (can be delayed)

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

I ain't got nothing chief.

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Added swat suit
- add: Added swat crate
- add: Added new crate category for secure reinforced crates
- tweak: Tweaked security supplies and crates
- tweak: Tweaked the price of Cybersun's tacsuits because apparently
they weren't charging enough to properly scam salvage techs.
- tweak: Tweaked `StructuralMetallicStrong` structural protection from
10 to 80

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
  • Loading branch information
BlueHNT and VMSolidus authored Dec 30, 2024
1 parent e4a2c0c commit eb1dde1
Show file tree
Hide file tree
Showing 16 changed files with 136 additions and 25 deletions.
5 changes: 3 additions & 2 deletions Resources/Prototypes/Catalog/Cargo/cargo_hardsuits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,14 @@
group: market

# Security
# Can't abuse em if you only got 1, good luck spamming frezon
- type: cargoProduct
id: SecurityShanlinTacsuit
icon:
sprite: Nyanotrasen/Clothing/OuterClothing/ReverseEngineering/syndicate.rsi
state: icon
product: CrateSecurityShanlinTacsuit
cost: 17500
cost: 75000
category: cargoproduct-category-name-hardsuits
group: market

Expand All @@ -57,7 +58,7 @@
sprite: Nyanotrasen/Clothing/OuterClothing/ReverseEngineering/juggernaut.rsi
state: icon
product: CrateSecurityGuanYuTacsuit
cost: 30000
cost: 125000
category: cargoproduct-category-name-hardsuits
group: market

Expand Down
12 changes: 11 additions & 1 deletion Resources/Prototypes/Catalog/Cargo/cargo_security.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,23 @@
category: cargoproduct-category-name-security
group: market

- type: cargoProduct
id: SecuritySwat
icon:
sprite: DeltaV/Clothing/OuterClothing/Armor/riot.rsi # DeltaV - resprite
state: icon
product: CrateSecuritySwat
cost: 12500
category: cargoproduct-category-name-security
group: market

- type: cargoProduct
id: SecuritySupplies
icon:
sprite: Objects/Storage/boxes.rsi
state: box_security
product: CrateSecuritySupplies
cost: 500
cost: 1000
category: cargoproduct-category-name-security
group: market

Expand Down
32 changes: 26 additions & 6 deletions Resources/Prototypes/Catalog/Fills/Crates/security.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
- type: entity
id: CrateSecurityRiot
parent: CrateSecgear
name: swat crate
description: Contains two sets of riot armor, helmets, shields, and enforcers loaded with beanbags. Extra ammo is included. Requires Armory access to open.
name: riot crate
description: Contains two sets of riot armor, helmets, shields, and enforcers loaded with beanbags. Extra ammo is included. Requires Security access to open.
components:
- type: StorageFill
contents:
Expand All @@ -56,7 +56,27 @@
amount: 2
- id: RiotShield
amount: 2
# - SecGasmask
- id: ClothingMaskGasSecurity
amount: 2

- type: entity
id: CrateSecuritySwat
parent: CrateSecgear
name: swat crate
description: Contains two sets of all encompassing swat suits. Requires Security access to open.
components:
- type: StorageFill
contents:
- id: ClothingOuterArmorSwat
amount: 2
- id: ClothingHeadHelmetSwat
amount: 2
- id: ClothingMaskGasSwat
amount: 2
- id: ClothingHandsGlovesCombat
amount: 2
- id: ClothingShoesSwat
amount: 2

- type: entity
id: CrateSecuritySupplies
Expand All @@ -68,9 +88,9 @@
contents:
- id: BoxHandcuff
- id: BoxSechud
# - SecBelt
# - SecGasmask
# - SpacelawBook
- id: ClothingBeltSecurityFilled
- id: ClothingMaskGasSecurity
- id: BookSecurity # replace with lawbook at some point

- type: entity
id: CrateRestraints
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/Damage/modifier_sets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
Slash: 10
Piercing: 10
Heat: 10
Structural: 10
Structural: 80

- type: damageModifierSet
id: StructuralMetallic
Expand Down
4 changes: 2 additions & 2 deletions Resources/Prototypes/DeltaV/Catalog/Cargo/cargo_armory.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
sprite: Nyanotrasen/Objects/Weapons/Guns/Pistols/universal.rsi
state: icon
product: CrateArmoryUniversal
cost: 6500
cost: 22500
category: Armory
group: market

Expand All @@ -37,7 +37,7 @@
cost: 5500
category: Armory
group: market

- type: cargoProduct
id: ArmoryEnergyGunMini
icon:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
amount: 2
- id: BoxLethalshot
amount: 3

- type: entity
id: CrateArmoryEnergyGun
parent: CrateWeaponSecure
Expand Down
19 changes: 11 additions & 8 deletions Resources/Prototypes/Entities/Clothing/Head/helmets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

#SWAT Helmet
- type: entity
parent: ClothingHeadBase
parent: [ClothingHeadBase, ClothingHeadEVAHelmetBase]
id: ClothingHeadHelmetSwat
name: SWAT helmet
description: An extremely robust helmet, commonly used by paramilitary forces. This one has the Nanotrasen logo emblazoned on the top.
Expand All @@ -46,15 +46,18 @@
sprite: Clothing/Head/Helmets/swat.rsi
- type: Clothing
sprite: Clothing/Head/Helmets/swat.rsi
- type: Armor #This is intentionally not spaceproof, when the time comes to port the values from SS13 this should be buffed from what it was.
- type: PressureProtection
highPressureMultiplier: 0.45
lowPressureMultiplier: 1000
- type: Armor
modifiers:
coefficients:
Blunt: 0.80
Slash: 0.80
Piercing: 0.80
Heat: 0.80
Radiation: 0.80
Caustic: 0.95
Blunt: 0.85
Slash: 0.85
Piercing: 0.85
Heat: 0.85
Radiation: 0.8
Caustic: 0.9
- type: ExplosionResistance
damageCoefficient: 0.75

Expand Down
29 changes: 29 additions & 0 deletions Resources/Prototypes/Entities/Clothing/OuterClothing/armor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,35 @@
damageCoefficient: 0.9
- type: GroupExamine

- type: entity
parent: [ClothingOuterBaseLarge, AllowSuitStorageClothing, ClothingOuterEVASuitBase]
id: ClothingOuterArmorSwat
name: swat suit
description: Composed of semi-flexible polycarbonate, reinforced materials, and integrated ballistic plating, it offers exceptional protection against melee, bullet, and environmental threats, ensuring officers remain combat-ready in the harshest conditions.
components:
- type: Sprite
sprite: Clothing/OuterClothing/Armor/swat.rsi
- type: Clothing
sprite: Clothing/OuterClothing/Armor/swat.rsi
- type: PressureProtection
highPressureMultiplier: 0.45
lowPressureMultiplier: 1000
- type: Armor
modifiers:
coefficients:
Blunt: 0.6
Slash: 0.6
Piercing: 0.6
Heat: 0.85
Radiation: 0.75
Caustic: 0.85
- type: ExplosionResistance
damageCoefficient: 0.50
- type: ClothingSpeedModifier # Burdensome for running, but perfect for speedy gliding, even though running is still probably better
walkModifier: 0.9
sprintModifier: 0.7
- type: GroupExamine

- type: entity
parent: ClothingOuterArmorBasic
id: ClothingOuterArmorBulletproof
Expand Down
4 changes: 3 additions & 1 deletion Resources/Prototypes/Entities/Clothing/Shoes/specific.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
sprintModifier: 1.3

- type: entity
parent: ClothingShoesBaseButcherable
parent: ClothingShoesMilitaryBase
id: ClothingShoesSwat
name: swat shoes
description: When you want to turn up the heat.
Expand All @@ -136,6 +136,8 @@
sprite: Clothing/Shoes/Specific/swat.rsi
- type: Clothing
sprite: Clothing/Shoes/Specific/swat.rsi
- type: ClothingSlowOnDamageModifier
modifier: 0.5

- type: entity
parent: ClothingShoesBaseButcherable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,3 +149,23 @@
- Energy
reflectProb: 0.2
spread: 90

- type: entity
parent: CrateBaseSecure
id: CrateBaseSecureReinforced
suffix: Secure, Reinforced
components:
- type: Destructible
thresholds:
- trigger:
!type:DamageTrigger
damage: 150
behaviors:
- !type:DoActsBehavior
acts: ["Destruction"]
- !type:PlaySoundBehavior
sound:
collection: MetalBreak
- type: Damageable
damageContainer: StructuralInorganic
damageModifierSet: StructuralMetallicStrong
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@
access: [["Hydroponics"]]

- type: entity
parent: CrateBaseSecure
parent: CrateBaseSecureReinforced
id: CrateWeaponSecure
name: secure weapon crate
components:
Expand All @@ -309,8 +309,8 @@
access: [["Armory"]]

- type: entity
parent: CrateBaseSecure
suffix: Armory, Secure
parent: CrateBaseSecureReinforced
suffix: Armory, Secure, Reinforced
id: CrateContrabandStorageSecure
name: contraband storage crate
description: An armory access locked crate for storing contraband confiscated from suspects or prisoners.
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 26 additions & 0 deletions Resources/Textures/Clothing/OuterClothing/Armor/swat.rsi/meta.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Taken from https://github.com/ParadiseSS13/Paradise. Inhands by BlueHNT.",
"size": {
"x": 32,
"y": 32
},
"states": [
{
"name": "icon"
},
{
"name": "equipped-OUTERCLOTHING",
"directions": 4
},
{
"name": "inhand-left",
"directions": 4
},
{
"name": "inhand-right",
"directions": 4
}
]
}

0 comments on commit eb1dde1

Please sign in to comment.