Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClothingAddFaction Doesn't work well. #1151

Open
Peptide90 opened this issue Oct 27, 2024 · 1 comment
Open

ClothingAddFaction Doesn't work well. #1151

Peptide90 opened this issue Oct 27, 2024 · 1 comment
Labels
Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Type: Bug [Un]intentional issue with something

Comments

@Peptide90
Copy link
Contributor

Description

We found this on N14 when adding the component to IDs to allow players to change factions, however the upstream ClothingUniformMailCarrier also uses the component to add Mailman faction.

The issue for us is we use turrets which are hostile to one faction, but friendly to another, and adding the friendly faction doesn't overwrite the existing faction, so people still get shot.

This change or addition would mean you could sneak onto a syndicate ship if you manage to get a syndicate hardsuit or uniform for example, as it will be the same code issue.

Media

Example Screenshot

@Peptide90 Peptide90 added Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Type: Bug [Un]intentional issue with something labels Oct 27, 2024
@sapphirescript
Copy link
Contributor

This should be solved with #1407 as it allows you to do fancier functions with factions and clothing, but you'd have to try it out. @Peptide90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Type: Bug [Un]intentional issue with something
Projects
None yet
Development

No branches or pull requests

2 participants