Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybind Search Bar #1005

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Keybind Search Bar #1005

wants to merge 7 commits into from
+53 −1

Conversation

xTheLifex
Copy link

Description

This PR adds a Search bar to the Keybinds menu as a QOL feature.

TODO

  • Search bar
  • Search by the key bind values as well (maybe?)
  • Hide categories that have no results for them

Media

search.mp4

Changelog

🆑

  • add: Added a search bar to the keybinds menu

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files labels Oct 4, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, DEATHB4DEFEAT, Pspritechologist and OldDanceJacket and removed request for a team October 6, 2024 02:43
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 6, 2024
@FoxxoTrystan FoxxoTrystan added Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs labels Oct 6, 2024
@xTheLifex @DEATHB4DEFEAT
Apply suggestions from code review
ea6d0db 
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: TheLife <[email protected]>
@github-actions github-actions bot added the Changes: YML Changes any yml files label Oct 20, 2024
@xTheLifex xTheLifex mentioned this pull request Dec 10, 2024
Merged
2 tasks
stellar-novas
stellar-novas approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@stellar-novas stellar-novas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, will test in game and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellar-novas stellar-novas stellar-novas approved these changes

@sleepyyapril sleepyyapril sleepyyapril approved these changes

@DEATHB4DEFEAT DEATHB4DEFEAT DEATHB4DEFEAT approved these changes

@VMSolidus VMSolidus Awaiting requested review from VMSolidus VMSolidus was automatically assigned from Simple-Station/ee-maintainers

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist Pspritechologist was automatically assigned from Simple-Station/ee-maintainers

@OldDanceJacket OldDanceJacket Awaiting requested review from OldDanceJacket

Assignees

@xTheLifex xTheLifex

Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xTheLifex @DEATHB4DEFEAT @sleepyyapril @stellar-novas @FoxxoTrystan