Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Melee Contests #1069

Merged

Conversation

VMSolidus
Copy link
Member

Description

Default values for melee weapon contests were causing balance issues with Mobs that interacted with it, such as Carps being able to defeat the damage threshold of reinforced walls when the intention is that they shouldn't be able to. Also the logic on ContestDisadvantages was inverted, so this fixes that.

Changelog

🆑

  • fix: Fixed issues with Contests System that allowed mobs such as Space Carps to smash through barriers that were not intended to be breakable by said mobs.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Oct 17, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team October 17, 2024 06:42
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 17, 2024
@FoxxoTrystan FoxxoTrystan added Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Type: Bug [Un]intentional issue with something labels Oct 17, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 7f60931 into Simple-Station:master Oct 19, 2024
17 checks passed
DangerRevolution pushed a commit to DangerRevolution/Einstein-Engines that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Status: Needs Review Someone please review this Type: Bug [Un]intentional issue with something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants