[Feature] Generic Radial Selector Menu #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Remuchi <[email protected]>
github-actions
bot
added
Changes: C#
FoxxoTrystan
requested review from
a team,
VMSolidus,
DEATHB4DEFEAT,
Pspritechologist and
FoxxoTrystan
and removed request for
a team
FoxxoTrystan
added
Priority: 4-Low
VMSolidus
requested changes
Oct 17, 2024
There was a problem hiding this comment.
This is needed so that clicking on an item craft doesn't instantaneously craft between 7 and 14 of that item depending on your ping, and instead only crafts 1 per click. This also fixes the issue of the menu briefly following the cursor when opening it. The reason that was happening was because it was actually opening the menu 7 to 14 times in rapid succession under the mouse cursor due to misprediction.
Other than that, my testing shows that this system works just fine.
Signed-off-by: Remuchi <[email protected]>
VMSolidus
approved these changes
Oct 20, 2024
Aidenkrz
approved these changes
Oct 20, 2024
Peptide90
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced a generic radial selector menu. Switched shortconstructionsystem from it's own BUI to radial selector.
Changelog
no cl no fun (no changelog for players)