Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Talking Across Atmosphere #1089

Merged

Conversation

VMSolidus
Copy link
Member

Description

Fixes #1085 by making it so that being in a MapAtmosphere outright bypasses the check for "No talking in space!"

TODO

Don't merge this without testing it, and I haven't tested it yet.

Changelog

🆑

  • add: Being in an Atmosphere(such as Planets like Glacier & Nukieworld) bypasses the limitation of "NO TALKING IN SPACE"

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Oct 17, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, FoxxoTrystan, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team October 18, 2024 02:52
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 18, 2024
@FoxxoTrystan
Copy link
Contributor

@VMSolidus I have a request in this PR, if unable to do il do it but do you think you can add a language check and check if its a sign langauge?

just asking

@FoxxoTrystan FoxxoTrystan added Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs Type: Feature Creation of or significant changes to a feature labels Oct 18, 2024
@VMSolidus
Copy link
Member Author

@VMSolidus I have a request in this PR, if unable to do il do it but do you think you can add a language check and check if its a sign langauge?

just asking

No need, Sign language doesn't go through these two functions at all. It co-opt's its way into the Emote functions instead.

@FoxxoTrystan
Copy link
Contributor

@VMSolidus I have a request in this PR, if unable to do il do it but do you think you can add a language check and check if its a sign langauge?
just asking

No need, Sign language doesn't go through these two functions at all. It co-opt's its way into the Emote functions instead.

Sign Language does not use the emote functions.

@VMSolidus VMSolidus merged commit 9ddd967 into Simple-Station:master Oct 20, 2024
18 checks passed
Ichaie pushed a commit to Ichaie/Einstein-Engines that referenced this pull request Oct 20, 2024
VMSolidus added a commit to VMSolidus/Einstein-Engines that referenced this pull request Oct 20, 2024
VMSolidus added a commit to VMSolidus/Einstein-Engines that referenced this pull request Oct 20, 2024
VMSolidus added a commit that referenced this pull request Oct 20, 2024
This reverts commit 9ddd967.

Introduced a game crashing bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space Muting on Glacier
4 participants