-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port] Playing Cards #1451
base: master
Are you sure you want to change the base?
[Port] Playing Cards #1451
Conversation
RSI Diff Bot; head commit c5d4108 merging into 442e25b Resources/Textures/EstacaoPirata/Objects/Misc/cards.rsi
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't even looked at anything else, but this 100% needs to be a standalone component that specifically exists for this purpose. So you're going to need to also make a StripMenuHiddenComponent.
…se component rather than hard-coded card components
Description
This ports Playing Cards from:
Estacao Pirata...
Frontier...
and GoobStation...
More specifically, ports Goob-Station/Goob-Station#1215 and Goob-Station/Goob-Station#1311 sequentially.
In short...
TODO before review
Content.Client/Inventory/StrippableBoundUserInterface.cs:220
's "DRAFT TODO". Basically its me asking how to involve the thieving trait in the omission of the playing cards in the strip menu. Currently, it does not take into account the trait and simply obscures. (prolly dont take the trait into account, obscure regardless)Media
Changelog
🆑