Default Disable Traits Anticheat #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
sleepyyapril
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Traitsystem anticheat is apparently really good at yeeting players who join as a different job than the one they selected for their traits menu. A better solution would be to rework the latejoin system so that it simply prevents you from joining as any job that would have an invalid trait total(Trait points after all valid traits are applied being a negative number is the key here). However since doing that would require me spend 10 hours thoroughly reading a >1000 line function which has so many indentations that parts of it don't even fit on my 17" monitor, I'm electing to disable the system pending a rework.
Changelog
No changelog because we shouldn't be openly telling the players they can just cheat the traits menu lmao.