Modular Computer System #1556
Merged
Modular Computer System #1556
+278
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
sleepyyapril
requested changes
Jan 17, 2025
| if (args.Container.ID != component.DiskSlot) | ||
| return; | ||
|
|
||
| UpdateComputer(new Entity<ModularComputerComponent>(uid, component)); |
There was a problem hiding this comment.
You end up doing the same checks for UpdateComputer as you do below. You could easily remove those by putting this later.
There was a problem hiding this comment.
Wait, that works? If the function encounters a check like that, returning would exit out of InsertDisk?
There was a problem hiding this comment.
Yeah, but you do the same checks for InsertDisk as you do for UpdateComputer, just remove the checks on UpdateComputer and put this lower.
sleepyyapril
requested changes
Jan 17, 2025
|
D: ^ The face of someone who is afraid of localizations |
Signed-off-by: sleepyyapril <[email protected]>
Signed-off-by: sleepyyapril <[email protected]>
sleepyyapril
previously requested changes
Jan 17, 2025
|
Should be good now. I hope. Probably. |
VMSolidus
requested changes
Jan 17, 2025
Co-authored-by: VMSolidus <[email protected]> Signed-off-by: Eris <[email protected]>
VMSolidus
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports the Modular Computer system from Arcadis. I'll document it more later, for now just look to the provided .yml for reference.
TODO
(Not) Media
No.
Changelog
🆑 Eris