-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Martial Artist Rework + Fix MeleeWeapon Wizmerge Bugs #1560
Merged
VMSolidus
merged 13 commits into
Simple-Station:master
from
angelofallars:martial-artist-power-attack
Jan 17, 2025
Merged
Martial Artist Rework + Fix MeleeWeapon Wizmerge Bugs #1560
VMSolidus
merged 13 commits into
Simple-Station:master
from
angelofallars:martial-artist-power-attack
Jan 17, 2025
+199
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: YML
Changes any yml files
labels
Jan 16, 2025
SimpleStation14
changed the title
Martial artist power attack
Martial Artist Power Attack
Jan 16, 2025
…artial artist the trait
angelofallars
changed the title
Martial Artist Rework
Martial Artist Rework + Fix MeleeWeapon Wizmerge Issues
Jan 16, 2025
angelofallars
changed the title
Martial Artist Rework + Fix MeleeWeapon Wizmerge Issues
Martial Artist Rework + Fix MeleeWeapon Wizmerge Bugs
Jan 16, 2025
sleepyyapril
approved these changes
Jan 16, 2025
I wonder if I could do something similar to security where they can incapacitate with their fists inheriting aggressive grab from changeling PR. |
VMSolidus
approved these changes
Jan 17, 2025
SimpleStation14
added a commit
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: YML
Changes any yml files
Status: Needs Review
Someone please review this
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworks the Martial Artist trait, making it a more impactful and visually distinct trait.
The reworked Martial Artist trait is also given to the Boxers, Martial Artists and Gladiators.
Also reverted some wizmerge messery that messed up the melee attack rate again, and messed up pistol whipping by making the cooldowns of gunshots and melee attacks intertwined.
Also while we're at it, Natural Weapons Removal has been disabled for all species whose damage is pure Blunt, including Diona, Dwarf, Arachne and IPC. (IPC have 6 blunt so the trait would literally be a 0-point negative trait for them)
Technical Details
A new trait function has been added for Martial Artist:
TraitModifyUnarmed
, which modifies the player entity'sMeleeWeaponComponent
.The Claws, Talons, Natural Weapon Removal, and Striking Calluses traits have also been refactored under the hood to use
TraitModifyUnarmed
, instead of replacingMeleeWeaponComponent
which would wipe out all the changes made by the Martial Artist trait.Media
New Description
Martial Artist In Action
video-2025-01-16_14.57.mp4
Striking Calluses New Description
Natural Weapons Removal New Description
Changelog
🆑 Skubman