-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newtonian Singularity #1619
Merged
Merged
Newtonian Singularity #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Someone please review this
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
and removed
Status: Needs Review
Someone please review this
labels
Jan 20, 2025
hilarious |
What's the perf cost of this? Anything substantial? |
DEATHB4DEFEAT
approved these changes
Jan 20, 2025
Most likely negligible |
O(1) complexity, it's a minor amount of trivial math done on single entities at a time. So the cost is "Basically nonexistent". |
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>
sleepyyapril
approved these changes
Jan 21, 2025
SimpleStation14
added a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
Status: Needs Review
Someone please review this
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By request from the very same person who assisted with #1618
This PR ports(and fixes) space-wizards/space-station-14#23372 such that it works on modern Robust Toolbox.
This PR essentially makes it so that the Singularity (And Tesla by extension) inherit some of the momentum of objects thrown into them. Im practice it means that they now work more like they do in SS13, whereby if a traitor does not actively intervene in a Singuloose(such as by using a Singularity Beacon), the singularity will usually be "Blown back into space" by space wind throwing objects at it in retaliation to it eating engineering.
Media
293695808-65887ee9-7783-4212-9421-81414978c7d1.mp4
Changelog
🆑