Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet Another "OnPlayerSpawn" Crash Fix Attempt #1621

Conversation

VMSolidus
Copy link
Member

There absolutely should not be something deleting the player characters when starting a round.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jan 21, 2025
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@VMSolidus
Copy link
Member Author

I'm cherrypicking this now: space-wizards/space-station-14#28771
So that the antag selector will actually log what's causing the crashes

Make `MakeAntag()` log errors instead of throw
@VMSolidus VMSolidus merged commit 611cc19 into Simple-Station:master Jan 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants