Fix Gun Contests #1638
Merged
Fix Gun Contests #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
VMSolidus
approved these changes
Jan 23, 2025
| { | ||
| var timeSinceLastFire = (curTime - component.LastFire).TotalSeconds; | ||
| var newTheta = MathHelper.Clamp(component.CurrentAngle.Theta + component.AngleIncreaseModified.Theta - component.AngleDecayModified.Theta * timeSinceLastFire, component.MinAngleModified.Theta, component.MaxAngleModified.Theta); | ||
| component.CurrentAngle = new Angle(newTheta); | ||
| component.LastFire = component.NextFire; | ||
|
|
||
| // Convert it so angle can go either side. | ||
| var random = Random.NextFloat(-0.5f, 0.5f); | ||
| var random = user != null ? Random.NextFloat(-0.5f, 0.5f) / _contests.MassContest(user) : Random.NextFloat(-0.5f, 0.5f); |
There was a problem hiding this comment.
Suggested change
| var random = user != null ? Random.NextFloat(-0.5f, 0.5f) / _contests.MassContest(user) : Random.NextFloat(-0.5f, 0.5f); | |
| var random = Random.NextFloat(-0.5f, 0.5f) / _contests.MassContest(user); |
Actually it is capable of accepting Nullable UIDs as inputs, and will simply return 1 if the EntityUid is null. Making it safe to multiply or divide by without checking if the user is null in the first place since x / 1 = x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.