[3.0] Move external libraries to a separate directory (Libs) #8082
+107
−3,741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugo <[email protected]>
Signed-off-by: Bugo <[email protected]>
Signed-off-by: Bugo <[email protected]>
Signed-off-by: Bugo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves third-party libraries (Minify and ReCaptcha) to a separate subdirectory within Sources —
Libs.It also adds a command (see composer.json in the root) to update these libraries (experts can to configure this command to run before building the package so that the Libs folder is included in the SMF distribution package).
Also implemented are 2 of SMF's own classes, JS and CSS, which extend the external classes MatthiasMullie\Minify\JS and MatthiasMullie\Minify\CSS respectively. This is done to add an additional comment at the top of each minimized file (previously this required changes to the updated Minify.php each time).
This way, external libraries can be easily updated with each release.
Fixes #7977