Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch message for quotefast action via Msg object #8335

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

live627
Copy link
Contributor

@live627 live627 commented Nov 1, 2024

Motivation

I have a modification (Topic Descriptions) that needs access to this, so we'll use Msg::load() which eventually calls integrate_query_message

Idea

$query_customizations could become its own object.

@live627 live627 added Housekeeping SMF code reorganization Hooks labels Nov 1, 2024
@jdarwood007
Copy link
Member

Haven't run the code but looks good.

I'm in support of more objects for everything. It makes things much easier to develop. But we have to contend with how it would support customizations. Magic methods maybe can help there.

@DiegoAndresCortes
Copy link
Member

I like it, same thing we got for messageindex, the more places the better imo

@tyrsson
Copy link
Collaborator

tyrsson commented Nov 2, 2024

From a customization perspective. If you model the instances that need to support customization as Observable then mods can be notified via their own registered listeners.

Sources/Actions/QuoteFast.php Outdated Show resolved Hide resolved
@Sesquipedalian Sesquipedalian merged commit d44d12d into SimpleMachines:release-3.0 Nov 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hooks Housekeeping SMF code reorganization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants