Correct widget' Instance discard behaviour

lib/Internal.lua

@@ -148,7 +148,9 @@ return function(Iris: Types.Iris): Types.Internal
         self.value = newValue
         self.lastChangeTick = Iris.Internal._cycleTick
         for _, thisWidget: Types.Widget in self.ConnectedWidgets do
-            Internal._widgets[thisWidget.type].UpdateState(thisWidget)
+            if thisWidget.lastCycleTick ~= -1 then
+                Internal._widgets[thisWidget.type].UpdateState(thisWidget)
+            end
         end
 
         for _, callback in self.ConnectedFunctions do

lib/widgets/Combo.lua

@@ -447,7 +447,14 @@ return function(Iris: Types.Internal, widgets: Types.WidgetUtility)
             PreviewLabel.Text = if typeof(stateIndex) == "EnumItem" then stateIndex.Name else tostring(stateIndex)
         end,
         Discard = function(thisWidget: Types.Combo)
+			-- If we are discarding the current combo active, we need to hide it
+			if OpenedCombo and OpenedCombo == thisWidget then
+				OpenedCombo = nil
+				AnyOpenedCombo = false
+			end
+
             thisWidget.Instance:Destroy()
+            thisWidget.ChildContainer:Destroy()
             widgets.discardState(thisWidget)
         end,
     } :: Types.WidgetClass)

lib/widgets/Menu.lua

@@ -333,7 +333,21 @@ return function(Iris: Types.Internal, widgets: Types.WidgetUtility)
             end
         end,
         Discard = function(thisWidget: Types.Menu)
+            -- properly handle removing a menu if open and deleted
+            if AnyMenuOpen then
+                local parentMenu = thisWidget.parentWidget :: Types.Menu
+                local parentIndex: number? = table.find(MenuStack, parentMenu)
+                if parentIndex then
+                    EmptyMenuStack(parentIndex)
+                    if #MenuStack ~= 0 then
+                        ActiveMenu = parentMenu
+                        AnyMenuOpen = true
+                    end
+                end
+            end
+
             thisWidget.Instance:Destroy()
+            thisWidget.ChildContainer:Destroy()
             widgets.discardState(thisWidget)
         end,
     } :: Types.WidgetClass)

lib/widgets/Plot.lua

@@ -390,6 +390,7 @@ return function(Iris: Types.Internal, widgets: Types.WidgetUtility)
         end,
         Discard = function(thisWidget: Types.PlotLines)
             thisWidget.Instance:Destroy()
+            thisWidget.Tooltip:Destroy()
             widgets.discardState(thisWidget)
         end,
     } :: Types.WidgetClass)
@@ -640,6 +641,7 @@ return function(Iris: Types.Internal, widgets: Types.WidgetUtility)
         end,
         Discard = function(thisWidget: Types.PlotHistogram)
             thisWidget.Instance:Destroy()
+            thisWidget.Tooltip:Destroy()
             widgets.discardState(thisWidget)            
         end,
     } :: Types.WidgetClass)

lib/widgets/Tab.lua

@@ -322,7 +322,13 @@ return function(Iris: Types.Internal, widgets: Types.WidgetUtility)
             end
         end,
         Discard = function(thisWidget: Types.Tab)
+            if thisWidget.state.isOpened.value == true then
+                closeTab(thisWidget.parentWidget, thisWidget.Index)
+            end
+
             thisWidget.Instance:Destroy()
+            thisWidget.ChildContainer:Destroy()
+            widgets.discardState(thisWidget)
         end
     } :: Types.WidgetClass)
 end