Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Competitive-Rework-Rework #732

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Competitive-Rework-Rework #732

wants to merge 11 commits into from

Conversation

nikita1824
Copy link

@nikita1824 nikita1824 commented Jan 21, 2024 •
edited
Loading

Hello, recently we started to use files from this repo as the base for our servers and decided to share with listed bellow improvements:

  1. Replaced Predictable Plugin Unloader by Sir with Plugin Unload Protect (Plugins won't be unloaded if we don't want them to. See more details here):
  1. Reworked all configs from this repository:
  • Removed executing multiple configs by confoglcompmod at the same time to avoid problems with loading/unloading order;
  • Commented all cvars which are not found by confoglcompmod to track;
  • Added tracking for l4d_ready_enabled and l4d_ready_cfg_name cvars;
  • Made confoglcompmod and match_vote plugins to load in the end so when plugins unload there will be no error logs about invalid handles during setting/resetting cvars back to default;
    ⠀
    ⠀
  1. Updated confoglcompmod and match_vote plugins:
  • Replaced change match method, so now we can use !match, !forcematch, etc instead of !chmatch...don't remember all of them);
  • Removed executing multiple configs when match mode loaded (see the first paragraph in Configs rework info);
  • Added match name for debugger to see which config warns about problems ("Couldn't track cvar" or "Attempted to track cvar that is already is tracked", etc);
  • Added restart map timer when match mode is unloaded;

@nikita1824
confoglcompmod: tab to spaces
a5bae11
@nikita1824
Update confogl configs
12a872c
@nikita1824
Update confoglcompmod and match_vote
3aacc0b 
Replacing changematch with better method (!match during match mode active to change the match????)
@nikita1824
Correct small mistakes
630b916
@nikita1824
Add match name for debug module
0703f72
@nikita1824
Update confogl configs
b30f227 
L 01/21/2024 - 08:07:14: [CvarSettings] [zonemod] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:07:34: [CvarSettings] [zoneretro] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:07:54: [CvarSettings] [zm3v3] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:08:25: [CvarSettings] [zm2v2] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:08:47: [CvarSettings] [zm1v1] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:09:09: [CvarSettings] [neomod] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:09:30: [CvarSettings] [nextmod] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:09:51: [CvarSettings] [nextmod3v3] [c2m1_highway] Attempt to track ConVar z_tank_health, which is already being tracked.
L 01/21/2024 - 08:09:51: [CvarSettings] [nextmod3v3] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:10:26: [CvarSettings] [nextmod2v2] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:10:55: [CvarSettings] [nextmod1v1] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:11:16: [CvarSettings] [pmelite] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:11:16: [CvarSettings] [pmelite] [c2m1_highway] Could not find CVar specified (l4d2_deadstop_penalty)
L 01/21/2024 - 08:11:36: [CvarSettings] [deadman] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:11:36: [CvarSettings] [deadman] [c2m1_highway] Could not find CVar specified (confogl_ghost_warp)
L 01/21/2024 - 08:11:36: [CvarSettings] [deadman] [c2m1_highway] Could not find CVar specified (confogl_ghost_warp_reload)
L 01/21/2024 - 08:11:36: [CvarSettings] [deadman] [c2m1_highway] Could not find CVar specified (hc_bridge_car_damage)
L 01/21/2024 - 08:11:36: [CvarSettings] [deadman] [c2m1_highway] Could not find CVar specified (sm_uncinfblock_types)
L 01/21/2024 - 08:12:00: [CvarSettings] [acemodrv] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:12:00: [CvarSettings] [acemodrv] [c2m1_highway] Could not find CVar specified (l4d2_heq_allow_horde_during_tank)
L 01/21/2024 - 08:12:21: [CvarSettings] [amrv3v3] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:12:21: [CvarSettings] [amrv3v3] [c2m1_highway] Could not find CVar specified (l4d2_heq_allow_horde_during_tank)
L 01/21/2024 - 08:12:48: [CvarSettings] [amrv2v2] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:12:48: [CvarSettings] [amrv2v2] [c2m1_highway] Could not find CVar specified (l4d2_heq_allow_horde_during_tank)
L 01/21/2024 - 08:13:09: [CvarSettings] [amrv1v1] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:13:09: [CvarSettings] [amrv1v1] [c2m1_highway] Could not find CVar specified (l4d2_heq_allow_horde_during_tank)
L 01/21/2024 - 08:13:33: [CvarSettings] [eq] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:13:53: [CvarSettings] [eq3v3] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:14:16: [CvarSettings] [eq2v2] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:14:37: [CvarSettings] [eq1v1] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:15:20: [CvarSettings] [apex] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:15:42: [CvarSettings] [zonehunters] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:16:03: [CvarSettings] [zh3v3] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:16:26: [CvarSettings] [zh2v2] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
L 01/21/2024 - 08:16:50: [CvarSettings] [zh1v1] [c2m1_highway] Could not find CVar specified (confogl_boss_unprohibit)
@nikita1824
Update match_vote
2a5146a
@nikita1824
Fix convars not resetting when matchmode unloaded
023552a
@nikita1824
Fix convars not resetting when matchmode unloaded (2)
2a71f50
@nikita1824
Copy link
Author

nikita1824 commented Jan 21, 2024 •
edited
Loading

In addition I forgot to tell, I know that this is a global Pull Request and it adds pain in the ass to observe it and update configs which are not presented in this repo but I hope it will be usefull.
If you have any question, feel free to ask.

@nikita1824
Update slot_vote and match_vote
de747ef 
- get rid off mv_maxplayers from match_vote and add it to slot_vote (that makes more sense to put that code in slot_vote plugin);
- Update server.cfg and don't worry about resetting sv_maxplayers to set values, slot_vote takes care of it.
@nikita1824
Update match_vote.smx
12e75b3 
Recompile match_vote (Did I forget to update it?)
@SirPlease
Copy link
Owner

Quite a PR with some solid improvement suggestions.
I'm not entirely sold on the implementation of the plugin unload protector, even though it does tackle the minor issues we're currently facing.

I'll mark this as a suggestion for now and comb through it more when I have the time and energy to do so.
Appreciate the PR! 😄

@SirPlease SirPlease added the Suggestion Suggested change for the Github. label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Suggestion Suggested change for the Github.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita1824 @SirPlease