[l4d_tank_control_eq] Update #859
Open
+543
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the original logic, add more API to control the tank.
|
Comments in chinese, excellent =) |
|
Remove code comments or change the English, otherwise it may not be passed |
Remove chinese comments |
apples1949
approved these changes
Dec 23, 2024
Add missing translations
apples1949
approved these changes
Dec 23, 2024
| } | ||
|
|
||
| public int Native_GetWhosHadTank(Handle plugin, int numParams) |
There was a problem hiding this comment.
Tag public can be stripped cuz it's not necessary. Same as other non-forward functions.
| public int Native_GetWhosHadTank(Handle plugin, int numParams) | ||
| { | ||
| return view_as<int>(CloneHandle(h_whosHadTank, plugin)); |
There was a problem hiding this comment.
view_as<int> in not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the original logic, add more API to control the tank.