Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for MSSQL default intances with windows authentication #58

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

lennartfranke
Copy link

Removed the "IntegratedSecurity = false" property, so Integrated Secutiy will not be disabled on a new instance when using connection strings like 'Data Source=.;Integrated Security=True'.

Fixed also an issue on non-english windows version where the 'IIS Check' does not work.

Lennart Franke added 3 commits January 8, 2016 16:36
using the service name instead of the service display name to get the IIS service
removed the "IntegratedSecurity = false" property, so Integrated Secutiy will not be disabled on a new instance when using connection strings like 'Data Source=.;Integrated Security=True'
@AlenPelin
Copy link
Contributor

Generally IntegratedSecurity = false was added as a workaround for the issue when importing/exporting solutions between systems where on the one side IntegratedSecurity is used and on the other one is not. I cannot accept this pull request without proper testing so lets postpone it a little bit.

@lennartfranke
Copy link
Author

I should have split this into two separate pull requests but i saw you already implemented the fix for non-English locales with 1248c5a.

Regarding the IntegratedSecurity:
You are right, importing/exporting could be a problem, I don't had that in mind when creating the pull request.
The import pipeline seem to have it's own processor for updating the ConnectionStrings with SIM.Pipelines.Import.UpdateConnectionStrings which also using IntegratedSecurity = false.
I am not sure if it would be good when install and import would behave differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants