Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] FEAAS / BYOC Components are not visible on the page with running A/B test #1914

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Aug 30, 2024

Description / Motivation

BYOC / FEAAS components are not rendered on the page when A/B testing is applied
This is happening due to the wrong order of componentThemes, componentProps plugins. They should be executed after the personalizePlugin, since the personalizePlugin updates layout data and sets the proper variant, while themes/props plugins were executed using non-personalized data

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko merged commit e6585db into dev Aug 30, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/JSS-4053 branch August 30, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants