[templates/nextjs-sxa]: The background image in Container component has been fixed #SXA-7647 #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKechashin
approved these changes
Dec 10, 2024
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-7647-background-image-container-component
branch
from
474547b to
2fed8c9
Compare
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-7647-background-image-container-component
branch
from
2fed8c9 to
2eaed8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Fixed the background-image issue in the Container component for the pageState === 'edit' scenario.
Implemented correct parsing and formatting of the BackgroundImage parameter to ensure proper rendering during the edit mode.
Replaced UUID dashes with an empty string and prefixed the image path with
/sitecore/shell/-/media/.Extracted the background image processing logic into a reusable function getBackgroundStyle for better code organization and clarity.
Testing Details
Types of changes