[sitecore-jss-nextjs]: Improve performance for redirects #SXA-7834 #2003
Conversation
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
…ded to improve the performance of redirects. Additionally, a condition has been added to handle Netlify requests to reduce server load.
sc-ruslanmatkovskyi
force-pushed
the
bugifx/SXA-7834-improvement-perfomence-redirects
branch
from
f67d456 to
9879878
Compare
sc-ruslanmatkovskyi
changed the title
| } | ||
|
|
||
| // Skip prefetch requests | ||
| if (this.isPrefetch(req)) { |
There was a problem hiding this comment.
Let's add some explanation on the reason of skipping prefetch requests, for better understanding if other people will need to figure out the scenario
| locale, | ||
| }); | ||
| } else { | ||
| matchedQueryString = [ |
There was a problem hiding this comment.
To me looks like this bunch of code does almost the same what getPermutedQueryMatch does
do you just need to use the same method?
| pattern: redirect.pattern, | ||
| locale, | ||
| }); | ||
| if (req.headers.get('cdn-loop') === NAME_NETLIFY) { |
There was a problem hiding this comment.
Is there a better way to safely check for netlify? Env variables?
Another question - do we really need to do this check, since :261 line does almost the same what getPermutedQueryMatch does. Does it really optimize something? since the same reg exp is executed
|
|
||
| const REGEXP_CONTEXT_SITE_LANG = new RegExp(/\$siteLang/, 'i'); | ||
| const REGEXP_ABSOLUTE_URL = new RegExp('^(?:[a-z]+:)?//', 'i'); | ||
| const NAME_NETLIFY = 'netlify'; |
There was a problem hiding this comment.
In case you leave netlify check (see my question below)
| const NAME_NETLIFY = 'netlify'; | |
| const NETLIFY_CDN_HEADER = 'netlify'; |
Description / Motivation
A condition for prefetch requests has been added to improve the performance of redirects.
Additionally, a condition has been added to handle Netlify requests to reduce server load.
Testing Details
Types of changes