[sitecore-jss] Introduce separate flow for fetching streams #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addy-pathania
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Please see some comments.
Also, from my understanding this would be a breaking change and we wont be able to release a patch with this change.
Can't we do anything simple by directly processing the ReadStream in the previous if block the way we do in Sitemap.ts api file?
| @@ -16,7 +16,7 @@ Our versioning strategy is as follows: | |||
| ### 🐛 Bug Fixes | |||
|
|
|||
| * `[sitecore-jss-nextjs]` Fix Chromes editing mode when rendering host URL is internally redirected in XMCloud ([#2019](https://github.com/Sitecore/jss/pull/2019)) | |||
| * `[sitecore-jss]` NativeDataFetcher doesn't return stream response ([#2020](https://github.com/Sitecore/jss/pull/2020)) | |||
| * `[sitecore-jss]` NativeDataFetcher doesn't return stream response ([#2020](https://github.com/Sitecore/jss/pull/2020)[#2022](https://github.com/Sitecore/jss/pull/2022)) | |||
There was a problem hiding this comment.
Should this be under the breaking change section?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Follow up for #2020
Previous approach introduced a bug where every fetch operation response was considered a stream - because
response.bodyalways has typeReadableStream.An alterative approach is to explicitly state an intent of getting a stream - so we optionally pass a resneponse handler into the
fetchoperation and get what we need.Testing Details
Types of changes