Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial starterkit creation #1

Merged
merged 41 commits into from
Aug 27, 2024
Merged

Initial starterkit creation #1

merged 41 commits into from
Aug 27, 2024

Conversation

robearlam
Copy link
Member

This is the initial commit of code for the XM Cloud ASP.NET Core Starter Kit. Some notes about it's contents:

  • This is a replica of the new structure that has been approved for the Next.js starter kit (foundation head).
  • The repo favours a FED-First development approach as per the new direction for XM Cloud. The container based approach is still included here, and it's assets can be found in the local-containers folder.
  • The components included are a direct port of the same components found in the Next.js starter, replicating the logic and generated markup/css.
  • There are currently 2 components that haven't been ported over as we're blocked waiting for changes to the ASP.NET Core SDK (Navigation and FEaaS). Both of these are called out in the main README to ensure readers are aware.
  • The main README contains initial steps to run the repo locally against an XMC preview endpoint, using VS Dev Tunnels to connect Pages to the local developer machine. Work will need to be done to refine this process in the future but this will do for an initial beta release, so we can garner initial feedback.
  • This is currently using the "old" method of connecting to the XMC Preview and Edge endpoints, it needs updating to support the ContextID approach, but this is blocked until the SDK is supports this approach.

robearlam added 30 commits July 12, 2024 13:11
@robearlam robearlam added the enhancement New feature or request label Aug 21, 2024
@robearlam robearlam self-assigned this Aug 21, 2024
authoring/Directory.Build.targets Outdated Show resolved Hide resolved
headapps/aspnet-core-starter/Models/BaseModel.cs Outdated Show resolved Hide resolved
headapps/aspnet-core-starter/Program.cs Show resolved Hide resolved
local-containers/scripts/New-EdgeToken.ps1 Outdated Show resolved Hide resolved
@robearlam
Copy link
Member Author

@sc-ivanlieckens - Fixed up most of your comments and marked those as Resolved.

Added comments to the others that are still open above.

@sc-ivanlieckens
Copy link
Collaborator

@robearlam
Copy link
Member Author

How do we feel about https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-10.0/file-scoped-namespaces ?

I hadn't seen this feature was introduced, reducing indentation where possible is always good in my book. Implemented.

@robearlam robearlam merged commit 50b2e23 into main Aug 27, 2024
@robearlam robearlam deleted the initial-starterkit-creation branch August 27, 2024 02:50
MartinMiles added a commit to MartinMiles/xmcloud-starter-aspnetcore that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants