Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript #1749

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Update TypeScript #1749

merged 5 commits into from
Jan 28, 2025

Conversation

rcj-siteimprove
Copy link
Contributor

Updating to the newest TypeScript version revealed some unreachable code in a script which made the build fail. The unreachable code has been removed.

@rcj-siteimprove
Update TypeScript
28b8275 
Updating to the newest TypeScript version revealed some unreachable code
in a script which made the build faild. The unreachable code has been
removed.
@rcj-siteimprove rcj-siteimprove requested a review from a team as a code owner January 28, 2025 10:48
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 846699b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rcj-siteimprove rcj-siteimprove self-assigned this Jan 28, 2025
@rcj-siteimprove rcj-siteimprove added the internal Change that only affects internal APIs or other non-public aspects label Jan 28, 2025
@rcj-siteimprove
Copy link
Contributor Author

!pr extract

Jym77
Jym77 previously approved these changes Jan 28, 2025
View reviewed changes
@rcj-siteimprove rcj-siteimprove requested a review from Jym77 January 28, 2025 15:00
@rcj-siteimprove rcj-siteimprove added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 051b535 Jan 28, 2025
4 checks passed
@rcj-siteimprove rcj-siteimprove deleted the update-typescript branch January 28, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Jym77 approved these changes

Assignees

@rcj-siteimprove rcj-siteimprove

Labels
internal Change that only affects internal APIs or other non-public aspects
Projects
⚙️ Alfa Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcj-siteimprove @Jym77