Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hyphenation properties #1762

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Add support for hyphenation properties #1762

wants to merge 21 commits into from

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Feb 21, 2025

Preliminary work for #1710

@Jym77 Jym77 self-assigned this Feb 21, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 5b9d4d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 80 packages
Name Type
@siteimprove/alfa-result Minor
@siteimprove/alfa-style Minor
@siteimprove/alfa-test Minor
@siteimprove/alfa-act Minor
@siteimprove/alfa-css-feature Minor
@siteimprove/alfa-css Minor
@siteimprove/alfa-dom Minor
@siteimprove/alfa-http Minor
@siteimprove/alfa-iana Minor
@siteimprove/alfa-parser Minor
@siteimprove/alfa-rules Minor
@siteimprove/alfa-toolchain Minor
@siteimprove/alfa-url Minor
@siteimprove/alfa-web Minor
@siteimprove/alfa-xpath Minor
@siteimprove/alfa-aria Minor
@siteimprove/alfa-painting-order Minor
@siteimprove/alfa-affine Minor
@siteimprove/alfa-branched Minor
@siteimprove/alfa-cache Minor
@siteimprove/alfa-cascade Minor
@siteimprove/alfa-comparable Minor
@siteimprove/alfa-emitter Minor
@siteimprove/alfa-equatable Minor
@siteimprove/alfa-flags Minor
@siteimprove/alfa-fnv Minor
@siteimprove/alfa-future Minor
@siteimprove/alfa-generator Minor
@siteimprove/alfa-graph Minor
@siteimprove/alfa-lazy Minor
@siteimprove/alfa-list Minor
@siteimprove/alfa-map Minor
@siteimprove/alfa-math Minor
@siteimprove/alfa-network Minor
@siteimprove/alfa-option Minor
@siteimprove/alfa-predicate Minor
@siteimprove/alfa-promise Minor
@siteimprove/alfa-record Minor
@siteimprove/alfa-rectangle Minor
@siteimprove/alfa-refinement Minor
@siteimprove/alfa-selective Minor
@siteimprove/alfa-selector Minor
@siteimprove/alfa-sequence Minor
@siteimprove/alfa-slice Minor
@siteimprove/alfa-string Minor
@siteimprove/alfa-table Minor
@siteimprove/alfa-thenable Minor
@siteimprove/alfa-thunk Minor
@siteimprove/alfa-time Minor
@siteimprove/alfa-trampoline Minor
@siteimprove/alfa-trilean Minor
@siteimprove/alfa-tuple Minor
@siteimprove/alfa-wcag Minor
@siteimprove/alfa-applicative Minor
@siteimprove/alfa-array Minor
@siteimprove/alfa-bits Minor
@siteimprove/alfa-callback Minor
@siteimprove/alfa-clone Minor
@siteimprove/alfa-collection Minor
@siteimprove/alfa-compatibility Minor
@siteimprove/alfa-continuation Minor
@siteimprove/alfa-device Minor
@siteimprove/alfa-earl Minor
@siteimprove/alfa-either Minor
@siteimprove/alfa-encoding Minor
@siteimprove/alfa-foldable Minor
@siteimprove/alfa-functor Minor
@siteimprove/alfa-hash Minor
@siteimprove/alfa-iterable Minor
@siteimprove/alfa-json-ld Minor
@siteimprove/alfa-json Minor
@siteimprove/alfa-mapper Minor
@siteimprove/alfa-monad Minor
@siteimprove/alfa-performance Minor
@siteimprove/alfa-reducer Minor
@siteimprove/alfa-rng Minor
@siteimprove/alfa-sarif Minor
@siteimprove/alfa-set Minor
@siteimprove/alfa-test-deprecated Minor
@siteimprove/alfa-tree Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Feb 21, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 24, 2025
View reviewed changes
packages/alfa-style/test/property/word-wrap.tsx
@@ -0,0 +1,80 @@
import { Device } from "@siteimprove/alfa-device";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused import Device.

Copilot Autofix AI 2 days ago

To fix the problem, we need to remove the unused import statement for Device from the file packages/alfa-style/test/property/word-wrap.tsx. This will clean up the code and eliminate any confusion caused by the presence of an unused import.

  • Locate the import statement for Device at the top of the file.
  • Remove the line containing the import statement.
  • Ensure that the removal does not affect any other part of the code.
Suggested changeset 1
packages/alfa-style/test/property/word-wrap.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/alfa-style/test/property/word-wrap.tsx b/packages/alfa-style/test/property/word-wrap.tsx
--- a/packages/alfa-style/test/property/word-wrap.tsx
+++ b/packages/alfa-style/test/property/word-wrap.tsx
@@ -1,2 +1 @@
-import { Device } from "@siteimprove/alfa-device";
 import { h } from "@siteimprove/alfa-dom";
EOF
@@ -1,2 +1 @@
import { Device } from "@siteimprove/alfa-device";
import { h } from "@siteimprove/alfa-dom";
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jym77 Jym77

Labels
minor Backwards-compatible change that touches public API
Projects
⚙️ Alfa Development
Status: 🧑‍💻 Doing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jym77