Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking improvements #11

Open
wants to merge 1 commit into
base: 1.0.0
Choose a base branch
from
Open

Tracking improvements #11

wants to merge 1 commit into from

Conversation

jpatacz
Copy link
Contributor

@jpatacz jpatacz commented Mar 16, 2022

No description provided.

skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
@jpatacz jpatacz requested a review from flskillcorner March 23, 2022 16:57
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Outdated Show resolved Hide resolved
@flskillcorner flskillcorner self-requested a review May 9, 2022 10:16
skillcorner/client.py Outdated Show resolved Hide resolved
skillcorner/client.py Show resolved Hide resolved
@jpatacz jpatacz force-pushed the tracking_improvements branch 7 times, most recently from 6cb1cb3 to 054d1b8 Compare May 11, 2022 13:29
@jpatacz jpatacz force-pushed the tracking_improvements branch from 6f03354 to 4309ff6 Compare May 16, 2022 09:46
@jpatacz
Copy link
Contributor Author

jpatacz commented May 16, 2022

I've updated get_and_save_match_tracking_data/get_and_save_physical docstrings by replacing ['df', 'python_structured_data'...] with ['csv', 'json', 'xml', 'txt'] but I'm not sure if it wouldn't be better to stay with the previous version because now it may wrongly suggest that those are the values that should be used as an output_format argument.

@jpatacz jpatacz force-pushed the tracking_improvements branch from d22aff0 to d924b2f Compare May 16, 2022 14:39
@jpatacz jpatacz force-pushed the tracking_improvements branch 2 times, most recently from f967dd7 to 147fcf6 Compare June 1, 2022 14:28
@jpatacz jpatacz force-pushed the tracking_improvements branch from 4002378 to d0247f9 Compare June 2, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants