Enhance & Fix Sign Text Expression #5465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
the
enhancement
TheLimeGlass
requested changes
Feb 20, 2023
NotSoDelayed
commented
Feb 28, 2023
Fusezion
suggested changes
Mar 20, 2023
Comment on lines
+76
to
+80
| if (matchedPattern == 1) { | ||
| line = (Expression<Number>) exprs[0]; | ||
| } else { | ||
| new SimpleLiteral<>(parseResult.mark, false); | ||
| } |
There was a problem hiding this comment.
you call new SimpleLiteral here but never set line to this, also a little lost on the change here outside of better readability
There was a problem hiding this comment.
I merged this with ternary but LimeGlass disagreed, so I reverted back to this.
There was a problem hiding this comment.
alright, then that's all
Fusezion
suggested changes
Mar 20, 2023
Comment on lines
56
to
+60
| Skript.registerExpression(ExprSignText.class, String.class, ExpressionType.PROPERTY, | ||
| "[the] line %number% [of %block%]", "[the] (1¦1st|1¦first|2¦2nd|2¦second|3¦3rd|3¦third|4¦4th|4¦fourth) line [of %block%]"); | ||
| "[the] lines [of %block%]", | ||
| "[the] line %number% [of %block%]", | ||
| "[the] (1¦1st|1¦first|2¦2nd|2¦second|3¦3rd|3¦third|4¦4th|4¦fourth) line [of %block%]" | ||
| ); |
There was a problem hiding this comment.
could the last pattern not be (1:(1st|first)|2:(2nd|second)|3:(3rd|third)|4:(4th|fourth)) for the matching?
we no longer need pipe lines and should stay back from those as ParseMark supports colons.
Do double check with the pattern tho but it should work like that
|
Closing in favour of #5797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A broom from Wal-Mart arrived to clean up ExprSignText which also allows for plural lines support!
Target Minecraft Versions: any
Requirements: any
Related Issues: #4576 (lines)