-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/registry classes #6695
Feature/registry classes #6695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, just a few thoughts
src/main/java/ch/njol/skript/classes/registry/RegistryClassInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking really good. almost there 😎
src/main/java/ch/njol/skript/classes/registry/RegistrySerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryClassInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryClassInfo.java
Outdated
Show resolved
Hide resolved
…er.java Co-authored-by: Patrick Miller <[email protected]>
…o.java Co-authored-by: Patrick Miller <[email protected]>
…o.java Co-authored-by: Patrick Miller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just one concern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work. do you plan to rework your enchantments pr to use this?
yes, so for the time being please ignore my enchant PR. |
Description
This PR aims to create a new set of classes based around the Bukkit Registry class.
The registry classes are based around EnumUtils, EnumClassInfo and EnumSerializer
Bukkit plans on using more registry things in the future.
As of right now the biome registry doesn't support custom biomes, but I believe the plan is to make that happen with 1.21
This allows Skript to get on board with registries and support stuff before we're forced to.
I believe Bukkit is also planning to drop enums for registry based classes, ie: Biomes, and switching to actual classes with static fields.
Another reason to prepare for the future.
Building off the same base of my Enchantments PR, a few things to note:
windswept hills
) will be used as namemy_thing:hot_spicy_biome
) will be used as nameI put this as a draft as I'm looking for feedback.
A lot was taken from the Enum classes for inspiration, but open to improvement.
I included registrant the Biome class info using this new method, to test/showcase how it works.
Target Minecraft Versions: any
Requirements: none
Related Issues: none