Skip to content

ExprExactItem #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 16, 2025
Merged

ExprExactItem #7738

merged 8 commits into from
Apr 16, 2025
+58 −0

Conversation

Absolutionism
Copy link
Contributor

Description

This PR aims to add an expression allowing users to grab exact item copies of blocks.
For example, a chest block with items in it, grabbing the exact item will give a chest item with the items from the chest block.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Absolutionism Absolutionism requested a review from a team as a code owner March 22, 2025 03:09
@Absolutionism Absolutionism requested review from APickledWalrus and Efnilite and removed request for a team March 22, 2025 03:09
@Absolutionism Absolutionism requested a review from sovdeeth March 22, 2025 03:20
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Mar 22, 2025
sovdeeth
sovdeeth approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still wishy washy about the syntax but i can't really think of much better without getting overly wordy

@Absolutionism Absolutionism requested a review from Efnilite March 22, 2025 14:05
@Absolutionism Absolutionism requested a review from Efnilite March 24, 2025 21:54
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Apr 6, 2025
@sovdeeth sovdeeth merged commit f90a607 into SkriptLang:dev/feature Apr 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Burbulinis Burbulinis Burbulinis requested changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Efnilite Efnilite Efnilite approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Absolutionism @sovdeeth @APickledWalrus @Efnilite @Burbulinis