Correctly handles webserver deployment failures

Skullabs · Aug 24, 2022 · 71c5f16 · 71c5f16
1 parent 6e38a7b
commit 71c5f16
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/kos-core/source/kos/core/VertxWebServer.java b/kos-core/source/kos/core/VertxWebServer.java
@@ -103,14 +103,18 @@ public void start() {
     public void start(Promise<Void> startFuture) {
         try {
             beforeStart();
-            tryToStartServer( startFuture );
+            tryToStartServer().onComplete(ar -> {
+                if (ar.succeeded()) startFuture.complete();
+                else startFuture.fail(ar.cause());
+            });
         } catch ( Throwable cause ) {
             log.error( "Could not start server", cause );
             startFuture.fail(cause);
         }
     }
 
-    private void tryToStartServer(Promise<Void> startFuture ) {
+    public Future<HttpServer> tryToStartServer() {
+        val startFuture = Promise.<HttpServer>promise();
         vertx.createHttpServer( kosContext.getHttpServerOptions() )
             .requestHandler( router() )
                 .listen( as -> {
@@ -120,9 +124,11 @@ private void tryToStartServer(Promise<Void> startFuture ) {
                         val server = as.result();
                         Runtime.getRuntime().addShutdownHook(new Thread(server::close));
                         afterStart(server);
-                        startFuture.complete();
+                        startFuture.complete(server);
                     }
                 });
+
+        return startFuture.future();
     }
 
     private void notifyWebServerDeploymentListeners() {